Allow all slices of state to be set #104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #103, this is a bunch of bookkeeping.
We set state in two places:
dust_system_set_state
dust_likelihood_run
viainitial
In the former especially it is useful to set a subset of possible states; this might be some state variables, some particles or some groups (the middle one is actually not that exciting most of the time). When we do this we might want to recycle one dimension of our input over all remaining inputs (so setting all particles to the same state vector).
This PR does all possible combinations of this. It's actually less terrible than it sounds, and most of the work is a little validation function
prepare_state
.There will be a few more of these type coming as we look to get
index_group
and similar args through basically every function that could possibly use them